chore(windows): switch Adoptium installation to ZIP archive instead of MSI - #2420
Merged
dduportal merged 1 commit intoJul 27, 2026
Merged
Conversation
…f MSI Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
chore/adoptium/zip-installers
branch
from
July 27, 2026 13:11
3dd9685 to
afc3e35
Compare
dduportal
marked this pull request as ready for review
July 27, 2026 13:12
dduportal
enabled auto-merge (squash)
July 27, 2026 13:12
MarkEWaite
approved these changes
Jul 27, 2026
MarkEWaite
left a comment
MarkEWaite
left a comment
Contributor
There was a problem hiding this comment.
Approved with an optional comment to consider removing a redundant command line argument. Approved whether or not the redundant argument is removed.
|
|
||
| echo '* RESOLVED BAKE CONFIG:' | ||
| docker buildx bake --file docker-bake.hcl --progress=quiet --print "${BAKE_TARGET}" | ||
| docker buildx bake --file docker-bake.hcl --file docker-bake.override.json --file docker-bake.override.json --progress=quiet --print "${BAKE_TARGET}" |
Contributor
There was a problem hiding this comment.
One command line argument for the override?
Suggested change
| docker buildx bake --file docker-bake.hcl --file docker-bake.override.json --file docker-bake.override.json --progress=quiet --print "${BAKE_TARGET}" | |
| docker buildx bake --file docker-bake.hcl --file docker-bake.override.json --progress=quiet --print "${BAKE_TARGET}" |
Contributor
Author
There was a problem hiding this comment.
sounds like a bad copy and paste from me, good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twin of jenkinsci/docker-ssh-agent#668 and jenkinsci/docker-agents#1263 (see jenkinsci/docker-agents#1265 also)
This PR cherry-picks the switch of Windows JDK installation from MSI (hard to debug and prone to many errors while we only need an OpenJDK directory) to ZIP.
Notes (same as the twin PRs):